Add: zeDeviceCanAccessPeer additional tests and missing maxClockRate#49
Open
Mihaau wants to merge 1 commit intooneapi-src:masterfrom
Open
Add: zeDeviceCanAccessPeer additional tests and missing maxClockRate#49Mihaau wants to merge 1 commit intooneapi-src:masterfrom
Mihaau wants to merge 1 commit intooneapi-src:masterfrom
Conversation
KapiX
requested changes
Sep 3, 2024
|
|
||
| bool foundPair = false; | ||
| for (size_t i = 0; i < all_devices.size() && !foundPair; ++i) { | ||
| for (size_t j = i + 1; j < all_devices.size(); ++j) { |
Contributor
There was a problem hiding this comment.
You could add && !foundPair here too and then remove the breaks
Comment on lines
403
to
406
| if (all_devices.size() < 2) { | ||
| LOG_INFO << "WARNING: Exiting as no multiple devices was found"; | ||
| GTEST_SKIP(); | ||
| } |
Contributor
There was a problem hiding this comment.
This test should be possible to run on single device. The point is to check if the same handle passed as first and second argument returns true.
…check GivenValidDeviceWhenRetrievingMemoryPropertiesThenValidPropertiesAreReturned maxClockRate zeDeviceCanAccessPeer: If both device and peer device are the same then return true. If both sub-device and peer sub-device are the same then return true. If both are sub-devices and share the same parent device then return true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GivenValidDeviceWhenRetrievingMemoryPropertiesThenValidPropertiesAreReturned:
maxClockRate
In zeDeviceCanAccessPeer:
If both device and peer device are the same then return true.
If both sub-device and peer sub-device are the same then return true.
If both are sub-devices and share the same parent device then return true.